Skip to content

Commit

Permalink
teams should not be empty array, not null
Browse files Browse the repository at this point in the history
  • Loading branch information
hubertdeng123 committed Oct 23, 2023
1 parent dd631a0 commit fff7d9a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/brain/githubMetrics/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ describe('github webhook', function () {
timeToTriageBy: null,
timeToRouteBy: null,
product_area: null,
teams: null,
teams: [],
},
{ schema: SCHEMA }
);
Expand Down
4 changes: 2 additions & 2 deletions src/utils/metrics.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ describe('metrics tests', function () {
target_id: 1,
target_name: 'Discussion Title',
target_type: 'discussion',
teams: null,
teams: [],
timeToRouteBy: null,
timeToTriageBy: null,
type: 'discussion',
Expand Down Expand Up @@ -292,7 +292,7 @@ describe('metrics tests', function () {
target_id: 1,
target_name: 'Discussion Title',
target_type: 'discussion',
teams: null,
teams: [],
timeToRouteBy: null,
timeToTriageBy: null,
type: 'discussion_comment',
Expand Down
2 changes: 1 addition & 1 deletion src/utils/metrics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export async function insertOss(
timeToRouteBy: null,
timeToTriageBy: null,
product_area: null,
teams: null,
teams: [],
};

if (eventType === 'issues') {
Expand Down

0 comments on commit fff7d9a

Please sign in to comment.