Changes to interfaces #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ediril
force-pushed
the
ft-sdk-intf-changes
branch
from
bb6763f
to
c203763
Compare
manjutapali
force-pushed
the
ft-sdk-intf-changes
branch
from
7c3b948
to
8b9df55
Compare
…proto files (#34) * fix python destination example * fixed tester issue
…face (#38) * fix(partner-sdk): updated the python example with updated proto interface * fix(python-example): refactored the code * fix(python-example): added field as part of kwargs
* added support for decimal params * incorporate comment
manjutapali
force-pushed
the
ft-sdk-intf-changes
branch
from
4bbf443
to
28aa76a
Compare
ediril
requested review from
manjutapali,
fivetran-abdulsalam and
fivetran-niketkhandelwal
and removed request for
fivetran-abdulsalam
* separated updated proto files into v2, updated build files * updated the README file * addressed requested changes * addressed requested changes * removed comment * removed naive_time from old proto * fixed python example * fixed go example * addressed comments * fix(fivetran-sdk): fixed the field number * refactor(Partner_sdk): Improvement in examples (#50) improvements in examples Co-authored-by: Satvik Patil <[email protected]> * addressed requested comments, fixed python destination example * removed note --------- Co-authored-by: SatvikPatil <[email protected]> Co-authored-by: Satvik Patil <[email protected]>
fivetran-abdulsalam
approved these changes
Jun 21, 2024
manjutapali
added a commit
that referenced
this pull request
Jun 24, 2024
This reverts commit 0a8c978.
ediril
added a commit
that referenced
this pull request
Jun 25, 2024
* Revert "fix(Destination): Merge file params into one (#54)" This reverts commit ad9b9d2. * Revert "Refactor(fivetran_sdk): Improvement destination examples (#55)" This reverts commit a229377. * Revert "Changes to interfaces (#32)" This reverts commit 0a8c978. * Revert "Update development-guide.md -- update grpc version" This reverts commit 4247c73. * revert to what is in production * remove extra newlines --------- Co-authored-by: emrah.diril <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.