Skip to content

Commit

Permalink
Revert "Changes to interfaces (#32)"
Browse files Browse the repository at this point in the history
This reverts commit 0a8c978.
  • Loading branch information
manjutapali committed Jun 24, 2024
1 parent 25f9f07 commit 05f1b08
Show file tree
Hide file tree
Showing 18 changed files with 345 additions and 1,030 deletions.
33 changes: 18 additions & 15 deletions common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ message TestResponse {
oneof response {
bool success = 1;
string failure = 2;
// potential future warning
}
}

Expand All @@ -78,13 +79,14 @@ enum DataType {
DECIMAL = 5;
FLOAT = 6;
DOUBLE = 7;
NAIVE_DATE = 8;
NAIVE_DATETIME = 9;
UTC_DATETIME = 10;
BINARY = 11;
XML = 12;
STRING = 13;
JSON = 14;
NAIVE_TIME = 8;
NAIVE_DATE = 9;
NAIVE_DATETIME = 10;
UTC_DATETIME = 11;
BINARY = 12;
XML = 13;
STRING = 14;
JSON = 15;
}

message DecimalParams {
Expand All @@ -108,14 +110,15 @@ message ValueType {
int64 long = 5;
float float = 6;
double double = 7;
google.protobuf.Timestamp naive_date = 8;
google.protobuf.Timestamp naive_datetime = 9;
google.protobuf.Timestamp utc_datetime = 10;
string decimal = 11;
bytes binary = 12;
string string = 13;
string json = 14;
string xml = 15;
google.protobuf.Timestamp naive_time = 8;
google.protobuf.Timestamp naive_date = 9;
google.protobuf.Timestamp naive_datetime = 10;
google.protobuf.Timestamp utc_datetime = 11;
string decimal = 12;
bytes binary = 13;
string string = 14;
string json = 15;
string xml = 16;
}
}

Expand Down
164 changes: 0 additions & 164 deletions common_v2.proto

This file was deleted.

2 changes: 1 addition & 1 deletion connector_sdk.proto
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,4 @@ message Record {

message Checkpoint {
string state_json = 1;
}
}
91 changes: 0 additions & 91 deletions connector_sdk_v2.proto

This file was deleted.

19 changes: 1 addition & 18 deletions destination_sdk.proto
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import "common.proto";
// Fivetran (grpc client) <> Destination (grpc server)
service Destination {
rpc ConfigurationForm (ConfigurationFormRequest) returns (ConfigurationFormResponse) {}
rpc Capabilities (CapabilitiesRequest) returns (CapabilitiesResponse) {}
rpc Test (TestRequest) returns (TestResponse) {}
rpc DescribeTable (DescribeTableRequest) returns (DescribeTableResponse) {}
rpc CreateTable(CreateTableRequest) returns (CreateTableResponse) {}
Expand All @@ -19,12 +18,6 @@ service Destination {
rpc WriteBatch (WriteBatchRequest) returns (WriteBatchResponse) {}
}

message CapabilitiesRequest {}

message CapabilitiesResponse {
BatchFileFormat batch_file_format = 1;
}

message DescribeTableRequest {
map<string, string> configuration = 1;
string schema_name = 2;
Expand Down Expand Up @@ -95,7 +88,6 @@ message WriteBatchRequest {
repeated string delete_files = 7;
oneof file_params {
CsvFileParams csv = 8;
ParquetFileParams parquet = 9;
}
}

Expand All @@ -106,20 +98,11 @@ message CsvFileParams {
string unmodified_string = 4;
}

message ParquetFileParams {
Encryption encryption = 1;
}

enum Encryption {
NONE = 0;
AES = 1;
}

enum BatchFileFormat {
CSV = 0;
PARQUET = 1;
}

enum Compression {
OFF = 0;
ZSTD = 1;
Expand All @@ -131,4 +114,4 @@ message WriteBatchResponse {
bool success = 1;
string failure = 2;
}
}
}
Loading

0 comments on commit 05f1b08

Please sign in to comment.