-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImplicitSpecies.n
can be space and time dependent
#886
Open
RemDelaporteMathurin
wants to merge
8
commits into
festim-dev:fenicsx
Choose a base branch
from
RemDelaporteMathurin:trap-density-space-time
base: fenicsx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ImplicitSpecies.n
can be space and time dependent
#886
RemDelaporteMathurin
wants to merge
8
commits into
festim-dev:fenicsx
from
RemDelaporteMathurin:trap-density-space-time
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #886 +/- ##
===========================================
+ Coverage 97.80% 97.84% +0.04%
===========================================
Files 44 44
Lines 2142 2182 +40
===========================================
+ Hits 2095 2135 +40
Misses 47 47 ☔ View full report in Codecov by Sentry. |
10 tasks
RemDelaporteMathurin
requested review from
jhdark
and removed request for
jhdark
November 3, 2024 00:42
RemDelaporteMathurin
added
enhancement
New feature or request
fenicsx
Issue that is related to the fenicsx support
labels
Nov 5, 2024
RemDelaporteMathurin
requested review from
jhdark
and removed request for
jhdark
November 9, 2024 18:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This fixes #644 by allowing the
n
attribute ofImplicitSpecies
to be a function ofx
andt
.Pinging @kaelyndunnell
Usage:
Step function:
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist