Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time space dependent trap density #782

Closed
wants to merge 5 commits into from

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

Implemented a time and space dependent trap density #644

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RemDelaporteMathurin RemDelaporteMathurin added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Jun 13, 2024
@RemDelaporteMathurin RemDelaporteMathurin linked an issue Jun 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 22 lines in your changes missing coverage. Please review.

Project coverage is 97.05%. Comparing base (3fc02da) to head (bc4636b).
Report is 226 commits behind head on fenicsx.

Files with missing lines Patch % Lines
festim/species.py 36.36% 21 Missing ⚠️
festim/hydrogen_transport_problem.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #782      +/-   ##
===========================================
- Coverage    98.39%   97.05%   -1.34%     
===========================================
  Files           28       28              
  Lines         1554     1594      +40     
===========================================
+ Hits          1529     1547      +18     
- Misses          25       47      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin mentioned this pull request Jun 13, 2024
10 tasks
@RemDelaporteMathurin
Copy link
Collaborator Author

Closing in favour of #886

@RemDelaporteMathurin RemDelaporteMathurin deleted the time_space_dependent_trap branch November 1, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fenicsx Issue that is related to the fenicsx support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trap density varies in space and time
1 participant