Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export implicit species #783

Draft
wants to merge 12 commits into
base: fenicsx
Choose a base branch
from
Draft

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

Fixes #781
Requires #782

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from main to fenicsx June 13, 2024 15:08
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (3fc02da) to head (3fc02da).
Report is 19 commits behind head on fenicsx.

Current head 3fc02da differs from pull request most recent head b31a8a0

Please upload reports for the commit b31a8a0 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #783   +/-   ##
========================================
  Coverage    98.39%   98.39%           
========================================
  Files           28       28           
  Lines         1554     1554           
========================================
  Hits          1529     1529           
  Misses          25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin added the fenicsx Issue that is related to the fenicsx support label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fenicsx Issue that is related to the fenicsx support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to export ImplicitSpecies concentration to VTX
1 participant