Mesh1D vertices to accept list

[JonathanGSDUFOUR]

Proposed changes

Added a setter for the vertices in Mesh_1D so that a list in input is converted to ndarray, the correct format.
There is also an added test to check if the format of the vertices is still good.

Types of changes

What types of changes does your code introduce to FESTIM?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code refactoring
• Documentation Update (if none of the other choices apply)
• New tests

Checklist

• Black formatted
• Unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71039f3) 98.87% compared to head (f8b8461) 99.07%.
Report is 71 commits behind head on fenicsx.

❗ Current head f8b8461 differs from pull request most recent head 0d279c6. Consider uploading reports for the commit 0d279c6 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           fenicsx     #665      +/-   ##
===========================================
+ Coverage    98.87%   99.07%   +0.19%     
===========================================
  Files           23       24       +1     
  Lines          974     1076     +102     
===========================================
+ Hits           963     1066     +103     
+ Misses          11       10       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jhdark]

Just some small changes to make

[jhdark]

You can update the documentation too

[jhdark]

Thanks Jonathon for your first contribution to festim !!! Hopefully the first of many! Any other changes from you @RemDelaporteMathurin

[RemDelaporteMathurin]

Hi @JonathanGSDUFOUR! Congrats for this first contribution! 🎉

A couple of comments on my side.

Also the coverage doesn't seem to be uploaded to Codecov.

@jhdark we may have to update the uploader in the github actions workflow.

[RemDelaporteMathurin]

@JonathanGSDUFOUR here's a tip to format your scripts.

Install black

pip install black

Then run:

black .

This will format all the files in the current directory.

Alternatively you can also install the black extension in Visual Studio Code (if you're using it)

[RemDelaporteMathurin]

@JonathanGSDUFOUR right I don't know why the linting is not passing... Maybe different versions of black? the workflow runs with black 23.12.0, what is your black version?

[JonathanGSDUFOUR]

When I managed to use black it was through pip install black in terminal, but it uses the 19.10b0 version, and when trying to use VSCode extension it doesn't seem to work (the extension is on version 23.10.1)

[RemDelaporteMathurin]

This is a very old version of black (2019!!)

Can you try to upgrade it with

pip install -U black

[RemDelaporteMathurin]

This looks good to me! Thanks @JonathanGSDUFOUR and congrats on your first contribution! 💯

@jhdark feel free to merge this