Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Vertices should accept a list #597

Closed
jhdark opened this issue Oct 12, 2023 · 2 comments · Fixed by #665
Closed

Mesh Vertices should accept a list #597

jhdark opened this issue Oct 12, 2023 · 2 comments · Fixed by #665
Labels
fenicsx Issue that is related to the fenicsx support good first issue Good for newcomers

Comments

@jhdark
Copy link
Collaborator

jhdark commented Oct 12, 2023

The vertices argument requires a shape at the moment, meaning it has to be an array. We could add a simple conversion to numpy array in case vertices are a list.
@jhdark jhdark added good first issue Good for newcomers fenicsx Issue that is related to the fenicsx support labels Oct 12, 2023
@RemDelaporteMathurin
Copy link
Collaborator

You can do that in the setter method of vertices

@RemDelaporteMathurin
Copy link
Collaborator

In the current code this is what we do:
https://github.com/RemDelaporteMathurin/FESTIM/blob/5c18f0fa7c824b0cf7ab80547aab447163fe258f/festim/meshing/mesh_from_vertices.py#L27

This ensures that vertices are a numpy array when passed to the mesher

@RemDelaporteMathurin RemDelaporteMathurin linked a pull request Dec 12, 2023 that will close this issue
Mesh1D vertices to accept list #665
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fenicsx Issue that is related to the fenicsx support good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mesh1D vertices to accept list JonathanGSDUFOUR/FESTIM
2 participants
@RemDelaporteMathurin @jhdark