Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing classes required on executeStopOnVMShutdown:true #1833

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

Smiche
Copy link
Contributor

@Smiche Smiche commented Oct 30, 2024

I encountered the following issue:
image

Using:

Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: C:\Program Files\apache-maven
Java version: 17.0.12, vendor: Eclipse Adoptium, runtime: C:\Program Files\Java\jdk-17.0.12+7
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Adding the two required classes to the Class loader resolved the issue. I didn't go in too deep why that check using Strings occurs.

Here's the execution config which lead to this:

					<execution>
						<id>remove-it-database</id>
						<goals>
							<goal>stop</goal>
						</goals>
						<configuration>
							<executeStopOnVMShutdown>true</executeStopOnVMShutdown>
							<removeVolumes>true</removeVolumes>
							<skip>${skipTests}</skip>
						</configuration>
						<phase>pre-integration-test</phase>
					</execution>

Copy link

sonarcloud bot commented Oct 30, 2024

@rhuss
Copy link
Collaborator

rhuss commented Oct 31, 2024

Thanks for spotting this! An alternative solution would be to remove Guava altogether from the code base, it doesn't add many benefits (except causing issues like these :)

@rohanKanojia wdyt ? On the other hand, this is a quick fix without any side-effects asfais, so would be happy to merge it, too.

@Smiche
Copy link
Contributor Author

Smiche commented Oct 31, 2024

Sounds like a better fix indeed. It was barely used for things that don't even need it. Great plugin by the way.

@rohanKanojia rohanKanojia merged commit 003398e into fabric8io:master Nov 3, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants