Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Guava dependency from project #1834

Open
rohanKanojia opened this issue Oct 31, 2024 · 4 comments
Open

Remove Guava dependency from project #1834

rohanKanojia opened this issue Oct 31, 2024 · 4 comments
Assignees

Comments

@rohanKanojia
Copy link
Member

Description

We should remove Guava dependency from project .

         Thanks for spotting this! An alternative solution would be to remove Guava altogether from the code base, it doesn't add many benefits (except causing issues like these :)

@rohanKanojia wdyt ? On the other hand, this is a quick fix without any side-effects asfais, so would be happy to merge it, too.

Originally posted by @rhuss in #1833 (comment)

@mdxabu
Copy link

mdxabu commented Nov 8, 2024

@rohanKanojia, Can you assign this to me?

@rohanKanojia
Copy link
Member Author

@mdxabu : Thanks, you can start by replacing Guava classes with inbuilt JDK replacements. I think for JIB functionality we do need guava dependency. Although we can remove the usage of Guava classes in our codebase.

@mdxabu
Copy link

mdxabu commented Nov 8, 2024

@mdxabu : Thanks, you can start by replacing Guava classes with inbuilt JDK replacements. I think for JIB functionality we do need guava dependency. Although we can remove the usage of Guava classes in our codebase.

@rohanKanojia, Is all modules using guava?

@rohanKanojia
Copy link
Member Author

We only have single module for docker-maven-plugin (in the src/ folder) . Rest of the modules are examples and integration tests. You only need to make changes in files in src/ directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants