Check Inno Setup is installed

[MichaelMcDonnell]

The build_installer.bat file uses Inno Setup to build the installer. It
does currently not check if Inno Setup is installed, and fails with the
message:
The system cannot find the path specified.
Build failed

That message does not explain how to fix the problem. I have added a
loop to search for Inno Setup 6 and 5. The user installed Inno Setup is
preferred over the system installed version. If Inno Setup cannot be
found then it prints an actionable error message.

I have tested it by:

1. Not having Inno Setup installed
2. Running build_installer.bat
3. Checked that the error message appears.
4. Installed Inno Setup 6 for my current user
5. Checked that the error message does not appear.
6. Checked that the installer package is generated
7. Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot
8. Verified that Barrier started
9. Uninstalled Barrier
10. Uninstalled Inno Setup 6
11. Installed Inno Setup 6 for all users
12. Checked that the error message does not appear.
13. Checked that the installer package is generated
14. Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot
15. Verified that Barrier started
16. Uninstalled Barrier
17. Uninstalled Inno Setup 6
18. Installed Inno Setup 5
19. Checked that the error message does not appear.
20. Checked that the installer package is generated
21. Installed build\installer-inno\bin\BarrierSetup-2.3.1-snapshot
22. Verified that Barrier started
23. Uninstalled Barrier

NOTE: There is an existing issue where you have to manually terminate barrierd.exe after Quitting Barrier. If you do not do that then the uninstaller will not be able to remove everything. It was reproduced with the latest release version (2.3.1).

Fixes #397

[AdrianKoshka]

I'd prefer if it could check for Inno Setup 5 and 6.

[MichaelMcDonnell]

Ok I'll look into checking for both Inno Setup 5 and 6.

[AdrianKoshka]

Thanks.

…

On Sun, Aug 18, 2019, 01:18 Michael Mc Donnell ***@***.***> wrote: Ok I'll look into checking for both Inno Setup 5 and 6. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#400?email_source=notifications&email_token=ACCJUTY5AE6EW6HRGKJGIBDQFDLQ3A5CNFSM4IMQLIE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QYW2Q#issuecomment-522292074>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACCJUT54P2OCMCOWJ7R7253QFDLQ3ANCNFSM4IMQLIEQ> .

[shymega]

@MichaelMcDonnell Why did you force-push?

[shymega]

Not that it matters, I was just curious. PR looks fine to me. Seeing as CI checks have passed, merging will be fine...

[MichaelMcDonnell]

@shymega I forced pushed because I used amend. Is there a better workflow?

Thanks!

[shymega]

@MichaelMcDonnell Its more that force pushing overwrites history, so its not really encouraged. Did you amend before you pushed, or after?

[MichaelMcDonnell]

I first did
'git commit --amend'

Then I used
'git push -f origin check-for-inno-setup'

[shymega]

Hmm. I always thought you didn't need to force-push, but maybe you do. Anyway, ignore me 😄 I've not amended commits for a long time... I generally queue them up, check them for mistakes throughly, and then push.

But yeah, we can definitely merge this PR in - checks have passed, and a quick scan over the Batch file, and you've certainly done a good job! 👍

[AdrianKoshka]

@MichaelMcDonnell Just want to double check and make sure, you've tested this yourself with innosetup 5 and 6, correct?

[MichaelMcDonnell]

@AdrianKoshka I did not try to install the package that was generated with Inno Setup 6. I can try that tonight.

[AdrianKoshka]

This comment is a good rubric for judging functionality: #357 (comment)

[MichaelMcDonnell]

I tested it with Inno Setup 5 and 6 (user and system install). All built versions of Barrier installed fine.

[MichaelMcDonnell]

I've filed the uninstall issue in issue #407

[walker0643]

@shymega Do you recall why this PR was held up? Inno is still on version 6 as of late 2021 so the changes would still be current. Thanks.

[shymega]

@walker0643 I don't recall why, but I bumped Inno to the next available. I'm no longer part of this project now, so I will most likely be devoting my time elsewhere, like my embedded firmware, and the fork. But I wish you luck. Thanks.

[shymega]

There's also two CI PRs that you might like to merge. I can't squash PRs now as I left the org, but feel free to squash into one commit for both PRs. They shouldn't conflict.