Pin Inno Setup 6 and Build with Inno Setup 6 on Azure Pipelines

[nelsonjchen]

No description provided.

[AdrianKoshka]

@nelsonjchen Should I merge this ASAP assuming CI passes?

[nelsonjchen]

I haven't had time to validate Inno Setup 6 working.

[AdrianKoshka]

What would need to be done to validate that it is working?

[nelsonjchen]

Ooh! That's a checklist. I guess for an installer:

• Make sure it installs the files on disks and adds an entry to Add or Remove Programs.
• Make sure the application works.
• Make sure it uninstalls the files and removes the entry in areas like the Add or Remove Programs
• definitely more

[shymega]

@nelsonjchen I'm going back through PRs. This branch is out of date with our master branch, so I'm just going to rebase, and we can see if CI passes. Not going to merge yet until we can get your checklist completed.

[nelsonjchen]

Whew, it's been far too long. I haven't had time to work on this issue and I've kind of lost my familiarity since then. Please do whatever you want to this PR and/or even replace it completely if you would like.

[shymega]

I've also bumped the Inno Setup version to the latest. We'll see if this passes. If @p12tic agrees that we should update Inno Setup, then we can merge, once everything is implemented.

[shymega]

Whew, it's been far too long. I haven't had time to work on this issue and I've kind of lost my familiarity since then. Please do whatever you want to this PR and/or even replace it completely if you would like.

No worries. I've been dedicating more time to Barrier in the last 24 hours than I have for some time now. I'm sorting out PRs, and adjusting our CI infra.

[p12tic]

Please test whether the produced installer actually works across the Windows versions that we currently support.

[shymega]

@p12tic Sure. I don't have access to any other Windows machine other than Windows 11 though - we may well need to ask the Barrier community to help...

[nelsonjchen]

@p12tic Sure. I don't have access to any other Windows machine other than Windows 11 though - we may well need to ask the Barrier community to help...

If you ever need quick, legal, and temporary virtual machines of Windows, I usually look at this:

https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

[shymega]

That's... really surprising, lol. My connection is pretty bad, so I'll have to download overnight...

[walker0643]

I agree with the version bump but the batch file modification will be unnecessary after #400 is merged. I suggest testing/merging both together.