Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

630 detherminal/autocomplete #645

Closed
wants to merge 2 commits into from
Closed

Conversation

sneurlax
Copy link
Member

@sneurlax sneurlax commented Aug 5, 2023

Thank you @detherminal

See #630
Closes #630
Closes #625

@sneurlax sneurlax changed the base branch from main to staging August 5, 2023 02:30
@sneurlax
Copy link
Member Author

sneurlax commented Aug 5, 2023

local tests pass, so tests may pass just from running from cypherstack/stack_wallet, let's see

@codecov-commenter
Copy link

Codecov Report

Merging #645 (34e9980) into staging (4991ca3) will decrease coverage by 0.04%.
Report is 19 commits behind head on staging.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           staging    #645      +/-   ##
==========================================
- Coverage     9.08%   9.05%   -0.04%     
==========================================
  Files          664     665       +1     
  Lines        73499   73779     +280     
==========================================
+ Hits          6681    6682       +1     
- Misses       66818   67097     +279     
Files Changed Coverage Δ
lib/electrumx_rpc/cached_electrumx.dart 14.81% <0.00%> (-0.19%) ⬇️
...views/restore_wallet_view/restore_wallet_view.dart 0.00% <0.00%> (ø)
lib/pages/monkey/monkey_view.dart 0.00% <0.00%> (ø)
lib/pages/ordinals/ordinal_details_view.dart 0.00% <0.00%> (ø)
lib/pages/send_view/confirm_transaction_view.dart 0.00% <0.00%> (ø)
...ges/special/firo_rescan_recovery_error_dialog.dart 0.00% <0.00%> (ø)
lib/pages/wallet_view/wallet_view.dart 0.00% <0.00%> (ø)
...my_stack_view/wallet_view/desktop_wallet_view.dart 0.00% <0.00%> (ø)
...ack_view/wallet_view/sub_widgets/desktop_send.dart 0.00% <0.00%> (ø)
...pecific/ordinals/desktop_ordinal_details_view.dart 0.80% <0.00%> (+<0.01%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

@sneurlax sneurlax marked this pull request as ready for review August 16, 2023 04:02
@julian-CStack
Copy link
Collaborator

reverted original auto focus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants