Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Shorter mnemonic words selected by autofill when typing in longer word (eg. typing carry, car autofilled, typing actor, act autofilled) #625

Closed
1 task done
sneurlax opened this issue Jul 25, 2023 · 3 comments

Comments

@sneurlax
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

On Linux desktop, when you restore a mnemonic phrase which contains words that contain valid words as substrings, the shorter substring is autofilled.

Expected Behavior

If an input is valid but also itself a substring of a longer valid word, focus should not switch automatically.

Reproduce Steps

Start typing "actor" and "act" will be recognized as a valid word, with focus switching to the next words' input. Type "carry", but "car" will be recognized and focus switched.

Environment

  • Operating system and version: Ubuntu 20.04

Logs

No response

Further Information

No response

@julian-CStack
Copy link
Collaborator

what if car is the actual word. Then you do want the focus to switch to next field. This unfortunately a side effect of doing auto-go-to-next-field. Not switching to next field on car is not a valid solution as that breaks consistency.
@rehrar thoughts?

@detherminal
Copy link
Contributor

I have opened the pr that makes it like: It checks if it is a valid word and there is a longer word available, if both, then it just shows empty (not invalid or valid) and user can go to next word by pressing it (then it shows valid if the previous one is valid). If the user continues writing from car to carry, it normally autocompletes and goes to the next one. I think this is the best practice.

@sneurlax
Copy link
Member Author

As referenced here, this issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants