-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/replace deprecated devcontainer image #431
Open
bj00rn
wants to merge
7
commits into
custom-components:master
Choose a base branch
from
bj00rn:chore/replace-deprecated-devcontainer-image
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c3a2526
add missing requirements.txt
bj00rn 852c6bc
upgrade devcontainer from integration_blueprint
bj00rn 89f2ae7
fix nordpool package not resolving correctly
bj00rn 377fcfd
make script executable
bj00rn dd19537
move configuration to config dir as per integration_blueprint
bj00rn 1a1a7ab
remove deprecated tasks
bj00rn 4df5055
add numpy dependency, seems to be required for onboarding
bj00rn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,42 @@ | ||
| // See https://aka.ms/vscode-remote/devcontainer.json for format details. | ||
| { | ||
| "image": "ghcr.io/ludeeus/devcontainer/integration:stable", | ||
| "image": "mcr.microsoft.com/devcontainers/python:3.12", | ||
| "name": "Nordpool integration development", | ||
| "context": "..", | ||
| "appPort": [ | ||
| "9123:8123" | ||
| ], | ||
| "postCreateCommand": "container install", | ||
| "extensions": [ | ||
| "ms-python.python", | ||
| "github.vscode-pull-request-github", | ||
| "ryanluker.vscode-coverage-gutters", | ||
| "ms-python.vscode-pylance" | ||
| // Mount the path to custom_components | ||
| // This let's us have the structure we want <root>/custom_components/integration_blueprint | ||
| // while at the same time have Home Assistant configuration inside <root>/config | ||
| // without resulting to symlinks. | ||
| "mounts": [ | ||
| "source=${localWorkspaceFolder}/custom_components,target=${containerWorkspaceFolder}/config/custom_components,type=bind,consistency=cached" | ||
| ], | ||
| "settings": { | ||
| "files.eol": "\n", | ||
| "editor.tabSize": 4, | ||
| "terminal.integrated.shell.linux": "/bin/bash", | ||
| "python.pythonPath": "/usr/bin/python3", | ||
| "python.analysis.autoSearchPaths": false, | ||
| "python.linting.pylintEnabled": true, | ||
| "python.linting.enabled": true, | ||
| "python.formatting.provider": "black", | ||
| "editor.formatOnPaste": false, | ||
| "editor.formatOnSave": true, | ||
| "editor.formatOnType": true, | ||
| "files.trimTrailingWhitespace": true | ||
| } | ||
|
|
||
| "postCreateCommand": "scripts/setup", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-python.python", | ||
| "github.vscode-pull-request-github", | ||
| "ryanluker.vscode-coverage-gutters", | ||
| "ms-python.vscode-pylance" | ||
| ], | ||
| "settings": { | ||
| "files.eol": "\n", | ||
| "editor.tabSize": 4, | ||
| "terminal.integrated.shell.linux": "/bin/bash", | ||
| "python.pythonPath": "/usr/bin/python3", | ||
| "python.analysis.autoSearchPaths": false, | ||
| "python.linting.pylintEnabled": true, | ||
| "python.linting.enabled": true, | ||
| "python.formatting.provider": "black", | ||
| "editor.formatOnPaste": false, | ||
| "editor.formatOnSave": true, | ||
| "editor.formatOnType": true, | ||
| "files.trimTrailingWhitespace": true | ||
| } | ||
| } | ||
| }, | ||
| "remoteUser": "vscode", | ||
| "features": {} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| colorlog==6.8.2 | ||
| homeassistant==2024.6.4 | ||
| pip>=21.3.1 | ||
| numpy | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this hass pinned here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the new devcontainer setup, HASS dependency is pinned here in requirements. These dependencies are for development only and are installed by the
setupscript. In the previous devcontainer setup I believe HASS was installed by default in the container image. The previous image also contained a script for selecting HASS version.The pin 2024.6 is from integration_blueprint and somewhat arbitrary I guess.