Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/replace deprecated devcontainer image #431

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bj00rn
Copy link
Contributor

@bj00rn bj00rn commented Oct 29, 2024

Upgrade devcontainer base image

Get devcontainer configuration up to date to make it easier to contribute.

BREAKING CHANGE: dev script will not work outside devcontainer.

fixes #365

@@ -0,0 +1,4 @@
colorlog==6.8.2
homeassistant==2024.6.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this hass pinned here?

Copy link
Contributor Author

@bj00rn bj00rn Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new devcontainer setup, HASS dependency is pinned here in requirements. These dependencies are for development only and are installed by the setup script. In the previous devcontainer setup I believe HASS was installed by default in the container image. The previous image also contained a script for selecting HASS version.

The pin 2024.6 is from integration_blueprint and somewhat arbitrary I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devcontainer image is deprecated
2 participants