Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyenv to uv based python and venv #303
pyenv to uv based python and venv #303
Changes from all commits
b415c16
63b8458
c60e49f
5e5b8ef
d178ab8
a3de1a2
f7e55c0
56067dd
fd5f9db
2232fe4
1bd9278
7bafbe4
8bd41f1
db09a10
58ad598
d434034
04d7a05
4ec3a41
c5f49df
6571d23
d91713b
8a36dae
5b4a0c9
f609d15
920962a
5b80d73
ed2e2f1
85ef729
87dd173
71f46b5
7763a31
f40e27d
6b22035
8cdd398
753f242
11ed4cb
f75ba91
ff5ae89
10ea20a
10e8f81
d7db0cf
3fbda24
2e1f21d
1837383
af505ef
e0d1b14
a4480ca
08b886f
9e313ba
ee5679b
d453fe0
537630b
9c46cf7
2efdb90
2b8a3f2
1aed813
d99c3fd
1b133a7
ece511e
e47a5e5
41e6dd6
69f9cd1
d61f3cd
3af0750
e7328c1
406e943
23f97a8
53e3723
02386fc
0ae90b9
6a9c466
b6d1fd0
62aa5a6
6468a9b
db232fd
fcc6da6
b0b5f1e
b3ee073
9905cbf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for? I suspect this has implications for other things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adeebshihadeh The XDG_DATA_HOME only sets the uv venv location (usr/local) otherwise the default location would fall to current directory (.venv).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it doesn't affect anything except providing the installation part for the venv. But we should avoid usage it /etc/profile as this will make it Into the envvars and might have some influence.