-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyenv to uv based python and venv #303
Conversation
@adeebshihadeh The remaining Todos and comments are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyQt5 needs to be cleaned up still, other than that LGTM
@adeebshihadeh I have the refactored PyQt5 to rebuild each time. The build time was 5mins which includes the docker cache. |
pip install does currently not work. Customs shims are not loaded properly. |
Also uv does currently not have a shim. I think we should have one if we ever intend to use uv on device. |
@robin-reckmann I checked the build logs and compile-pyqt5.sh ran without any errors. I have added back the custom shims export path in userspace/files/profile. |
userspace/compile-pyqt5.sh
Outdated
export PYENV_ROOT="/usr/local/pyenv" | ||
eval "$(pyenv init -)" | ||
eval "$(pyenv virtualenv-init -)" | ||
export XDG_DATA_HOME="/usr/local" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is also not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@robin-reckmann PR is ready if no other issues or concerns please confirm for @adeebshihadeh. |
This should've been a straightforward PR, but it's taken a lot of people's time now. Bounty is unlocked, @robin-reckmann you want to pick it up? |
resolves #240 and #30
UV based python uses optimized build
CONFIG_ARGS = "'--build=x86_64-unknown-linux-gnu' '--host=x86_64-unknown-linux-gnu' '--prefix=/install' '--with-openssl=/tools/deps' '--with-system-expat' '--with-system-libmpdec' '--without-ensurepip' '--with-readline=editline' '--enable-shared' '--enable-optimizations' '--with-lto`
UV based python is set to 3.12.3.
PyQt5 uses prebuilt wheels.
TODOs