Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing arbitrary options to fusermount #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow passing arbitrary options to fusermount #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/filesystem/virtual/configuration/fuse_mount_enabled.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ func (m *fuseMount) Expose(terminationGroup program.Group, rootDirectory virtual
FsName: m.fsName,
AllowOther: m.configuration.AllowOther,
DirectMount: m.configuration.DirectMount,
Options: m.configuration.Options,
})
if err != nil {
return util.StatusWrap(err, "Failed to create FUSE server")
Expand Down
160 changes: 85 additions & 75 deletions pkg/proto/configuration/filesystem/virtual/virtual.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pkg/proto/configuration/filesystem/virtual/virtual.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ message FUSEMountConfiguration {
//
// Recommended value: unset
map<string, string> linux_backing_dev_info_tunables = 9;

// List of options to pass directly to fusermount.
repeated string options = 10;
Copy link
Member

@EdSchouten EdSchouten Mar 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we describe what the semantics of this option are if direct_mount is used? Because then we don’t use fusermount, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to refer to man pages that people can use to get a full list of options that can be provided.

}

message NFSv4MountConfiguration {
Expand Down