Allow passing arbitrary options to fusermount #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the FUSE mount options to support passing a collection of textual options that are directly passed to fusermount. Fixes buildbarn/bb-clientd#6.
EdSchouten
reviewed
Mar 22, 2023
| @@ -133,6 +133,9 @@ message FUSEMountConfiguration { | |||
| // | |||
| // Recommended value: unset | |||
| map<string, string> linux_backing_dev_info_tunables = 9; | |||
|
|
|||
| // List of options to pass directly to fusermount. | |||
| repeated string options = 10; | |||
There was a problem hiding this comment.
Could we describe what the semantics of this option are if direct_mount is used? Because then we don’t use fusermount, right?
There was a problem hiding this comment.
Also make sure to refer to man pages that people can use to get a full list of options that can be provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the FUSE mount options to support passing a collection of textual options that are directly passed to fusermount.
Fixes buildbarn/bb-clientd#6.