Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASRockRack provider #196

Merged
merged 42 commits into from
Mar 23, 2021
Merged

Add ASRockRack provider #196

merged 42 commits into from
Mar 23, 2021

Commits on Mar 8, 2021

  1. Add methods, initial work to probe for ASRR BMCs

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a9e2dff View commit details
    Browse the repository at this point in the history

  2. providers/asrockrack: Implment BMC firmware update, version info methods

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d7ddf5d View commit details
    Browse the repository at this point in the history

  3. bmc: Add firmware update/getter interface methods

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    323d4d6 View commit details
    Browse the repository at this point in the history

  4. lint fixes

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    096dd80 View commit details
    Browse the repository at this point in the history

  5. asrockrack: firmware updates 

    - Fix up bmclib v2 interface implementation
- Firmware update method fixes
- Firmware update test fixes
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7307fa0 View commit details
    Browse the repository at this point in the history

  6. asrockrack: implement bmclib (older) v0 interface methods for compati… 

    …bility
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    9ba38e6 View commit details
    Browse the repository at this point in the history

  7. asrockrack: update info logging 

    non-even logr k/v fields results in empty logging lines with just the
prefix 'INFO' being logged, here we ensure all values are in pairs.
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3d049a5 View commit details
    Browse the repository at this point in the history

  8. asrockrack: add skipLogout bool to ignore Close() invocation 

    requests after a firmware flash, since the BMC is resetting at that
point
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    04bd8fd View commit details
    Browse the repository at this point in the history

  9. discover: fix ASRR probe test and rename file for consistency

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    08f6ec4 View commit details
    Browse the repository at this point in the history

  10. asrockrack: fix minor lint issues

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    4e6ac59 View commit details
    Browse the repository at this point in the history

  11. providers: implement stub Firmware interface methods

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    acb54b4 View commit details
    Browse the repository at this point in the history

  12. bmc/firmware: Add BIOS firmware interface methods

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6b41052 View commit details
    Browse the repository at this point in the history

  13. examples: purge testing leftovers

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d2c1eaa View commit details
    Browse the repository at this point in the history

  14. client: Add remaining FirmwareBIOS* interface methods 

    - purge unused driver registry
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a51c581 View commit details
    Browse the repository at this point in the history

  15. asrockrack: update log levels to 1

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c7a10f6 View commit details
    Browse the repository at this point in the history

  16. asrockrack: Add BIOS firmware update support

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    2dcefc2 View commit details
    Browse the repository at this point in the history

  17. Add v1, v2 bmclib client examples

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    22835e5 View commit details
    Browse the repository at this point in the history

  18. devices/interfaces: purge Firmware interface, its now made available … 

    …in the v2 interface
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8422ccd View commit details
    Browse the repository at this point in the history

  19. Add context paramter to Close() 

    This enables the existing codebase to be implemented by both the current
and newer interfaces.

the current interface (bmclib v0)
https://github.com/bmc-toolbox/bmclib/blob/c1fed9df833628df57796245d085c97187f06f9a/devices/interfaces.go

the newer interface (bmclib v2)
https://github.com/bmc-toolbox/bmclib/blob/c1fed9df833628df57796245d085c97187f06f9a/bmc/connection.go#L17
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d311fd6 View commit details
    Browse the repository at this point in the history

  20. Add methods, initial work to probe for ASRR BMCs

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    6441553 View commit details
    Browse the repository at this point in the history

  21. lint fixes

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    5c150f7 View commit details
    Browse the repository at this point in the history

  22. providers: implement stub Firmware interface methods

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    01f8923 View commit details
    Browse the repository at this point in the history

  23. providers/asrockrack: various linting fixes 

    based on feedback in PR#196
    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    2b52025 View commit details
    Browse the repository at this point in the history

  24. providers/asrockrack: move test init into TestMain

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    39b616a View commit details
    Browse the repository at this point in the history

  25. client: move asrockrack registry

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    9070351 View commit details
    Browse the repository at this point in the history

  26. providers/asrockrack: implement the registrar.Verifier interface

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    f099ec7 View commit details
    Browse the repository at this point in the history

  27. client: register asrockrack driver

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a688310 View commit details
    Browse the repository at this point in the history

  28. examples/v2: clean up since the provider driver is registered

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a09e661 View commit details
    Browse the repository at this point in the history

  29. client: point registry logger after opts are set

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    fa8e5f5 View commit details
    Browse the repository at this point in the history

  30. examples/v2: pass in logger to NewClient

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    7e81b00 View commit details
    Browse the repository at this point in the history

  31. bmc: update firmware interface to accept an io.Reader

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    f574d21 View commit details
    Browse the repository at this point in the history

  32. providers/asrockrack: accept a io.Reader interface

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    2081cd9 View commit details
    Browse the repository at this point in the history

  33. purge asrockrack references from the older discover/probe methods

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    bb6568f View commit details
    Browse the repository at this point in the history

  34. examples/v2: update to include the BMC FW flash example

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3bb9a04 View commit details
    Browse the repository at this point in the history

  35. examples: fix example versions

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    229dca9 View commit details
    Browse the repository at this point in the history

  36. providers/asrockrack: purge unused consts

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    c0c4dfc View commit details
    Browse the repository at this point in the history

  37. go mod tidy

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    56ed33d View commit details
    Browse the repository at this point in the history

  38. client: fix misalligned comment

    @joelrebel
    joelrebel committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    a514cb6 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. providers/asrockrack: purge unused context from struct

    @joelrebel
    joelrebel committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    bb18bfe View commit details
    Browse the repository at this point in the history

  2. devices/interfaces: purge older Firmware interface that crept back in… 

    … after rebase
    @joelrebel
    joelrebel committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    09da9d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. client, providers/asrockrack: purge unused context variable

    @joelrebel
    joelrebel committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    3a22d5e View commit details
    Browse the repository at this point in the history

  2. providers/asrockrack: fix redundant error checks

    @joelrebel
    joelrebel committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    8c2ffa9 View commit details
    Browse the repository at this point in the history