Add ASRockRack provider #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobweinstock I think we're ready with this one |
jacobweinstock
requested changes
Feb 17, 2021
zevweiss
reviewed
Feb 18, 2021
- Fix up bmclib v2 interface implementation - Firmware update method fixes - Firmware update test fixes
non-even logr k/v fields results in empty logging lines with just the prefix 'INFO' being logged, here we ensure all values are in pairs.
requests after a firmware flash, since the BMC is resetting at that point
- purge unused driver registry
…in the v2 interface
This enables the existing codebase to be implemented by both the current and newer interfaces. the current interface (bmclib v0) https://github.com/bmc-toolbox/bmclib/blob/c1fed9df833628df57796245d085c97187f06f9a/devices/interfaces.go the newer interface (bmclib v2) https://github.com/bmc-toolbox/bmclib/blob/c1fed9df833628df57796245d085c97187f06f9a/bmc/connection.go#L17
based on feedback in PR#196
jacobweinstock
approved these changes
Mar 20, 2021
There was a problem hiding this comment.
Left some comments but approved regardless. I'm assuming you want to merge #208 before this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now it provides methods to update the BMC firmware for the ASRR AMI BMCs