Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[bmqa]: Remove unused Session::impl() function #519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix[bmqa]: Remove unused Session::impl() function #519

wants to merge 1 commit into from

Commits on Nov 15, 2024

  1. Fix[bmqa]: Remove unused Session::impl() function 

    This function is not used within the BlazingMQ code, and exposes
publically the PIMPL implementation that is used by `bmqa::Session`.
Because we do not use this function, and because it is part of the
public (documented!) API, users could break our session invariants.
This patch removes this function from the API.  While this is a breaking
change, we do not want any user to be using this function, so we should
be okay with breaking them.

Signed-off-by: Patrick M. Niedzielski <[email protected]>
    @pniedzielski
    pniedzielski committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9a0d2f5 View commit details
    Browse the repository at this point in the history