Fix[bmqa]: Remove unused Session::impl() function
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallfox
approved these changes
Nov 15, 2024
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
This function is not used within the BlazingMQ code, and exposes publically the PIMPL implementation that is used by `bmqa::Session`. Because we do not use this function, and because it is part of the public (documented!) API, users could break our session invariants. This patch removes this function from the API. While this is a breaking change, we do not want any user to be using this function, so we should be okay with breaking them. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
fix/remove-session-impl
branch
from
7b73bc9
to
9a0d2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is not used within the BlazingMQ code, and exposes publically the PIMPL implementation that is used by
bmqa::Session. Because we do not use this function, and because it is part of the public (documented!) API, users could break our session invariants. This patch removes this function from the API. While this is a breaking change, we do not want any user to be using this function, so we should be okay with breaking them.