[FIX] Embedders - fix proxies, default on http, tests #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6028 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 315 315
Lines 67308 67317 +9
=======================================
+ Hits 58282 58291 +9
Misses 9026 9026 |
PrimozGodec
force-pushed
the
change-proxy-behaviour
branch
from
5653e55
to
9a46bd3
Compare
PrimozGodec
force-pushed
the
change-proxy-behaviour
branch
from
9a46bd3
to
7f83008
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Fix and error and default on HTTP when no scheme is provided with URL. The same default is used with other libraries, such as requests.
Includes