Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy addresses for embedders and NLTK #867

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

PrimozGodec
Copy link
Collaborator

Issue
  • get_proxy from core Orange is not working properly - it document affects embeddings
  • nltk needs explicit port address in proxy URL
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Fix proxies Fix proxy adresses for Jun 17, 2022
@PrimozGodec PrimozGodec changed the title Fix proxy adresses for Fix proxy addresses for embedders and NLTK Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #867 (3104d28) into master (c05b4fb) will increase coverage by 0.04%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   76.82%   76.87%   +0.04%     
==========================================
  Files          85       85              
  Lines       11942    11965      +23     
  Branches     1877     1880       +3     
==========================================
+ Hits         9175     9198      +23     
+ Misses       2463     2462       -1     
- Partials      304      305       +1     

@PrimozGodec PrimozGodec marked this pull request as ready for review June 20, 2022 08:18
@lanzagar lanzagar merged commit eecdb90 into biolab:master Jun 20, 2022
@PrimozGodec PrimozGodec deleted the fix-proxies branch June 20, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants