[FIX] OWLoadClassifier: Show message on unpickling error #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.90% (diff: 100%)@@ master #1752 diff @@
==========================================
Files 82 82
Lines 8819 8845 +26
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7838 7864 +26
Misses 981 981
Partials 0 0
|
kernc
suggested changes
Nov 16, 2016
| raise # TODO: error reporting | ||
| except os.error: | ||
| raise # TODO: error reporting | ||
| except (pickle.UnpicklingError, os.error, EOFError): |
There was a problem hiding this comment.
Gladly. It was there before, so I kept it, but I didn't like it either. Fixed.
janezd
force-pushed
the
loadclassifier-pickle-error
branch
from
e32c4ea
to
bde7ec7
Compare
kernc
approved these changes
Nov 16, 2016
kernc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Load Classifier widget crashes instead of reporting an error when unpickling fails.
Description of changes
Show the message.
Includes