Add Error Reporting #1749
Closed
Add Error Reporting #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Current coverage is 88.87% (diff: 100%)@@ master #1749 diff @@
==========================================
Files 82 82
Lines 8819 8819
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7838 7838
Misses 981 981
Partials 0 0
|
jayvdb
reviewed
Nov 14, 2016
| @@ -97,9 +97,9 @@ def load(self, filename): | |||
| try: | |||
| classifier = pickle.load(open(filename, "rb")) | |||
| except pickle.UnpicklingError: | |||
| raise # TODO: error reporting | |||
| raise pickle.UnpicklingError("Failed to load '{}'.".format(filename)) | |||
There was a problem hiding this comment.
Only one space should appear between raise and argument, here and below..
Please amend your commit.
prasastoadi
force-pushed
the
branch-1
branch
from
f4da797
to
c1fb74d
Compare
|
Thanks for noticing this and for contributing to Orange. However, the change you've made still raises an exception instead of showing a nicely formatted end-user-readable message, as widgets are supposed to. The actual fix is short, but requires understanding how error messages in widgets work. For demonstration, I implemented the fix for this bug myself. See the changes in PR #1752. Can you now find another widget that crashes due to user's fault (like this one) and add a similar fix there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
TODO: error reporting
Description of changes
Add error reporting
Includes