Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bpp_common): add unit test for safety check #9386

Merged
merged 5 commits into from
Nov 19, 2024
+297 −35

remove unecessary header and space

525ead7
Select commit
Loading
Failed to load commit list.
Merged

test(bpp_common): add unit test for safety check #9386

remove unecessary header and space
525ead7
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 19, 2024 in 47s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.21 (8.09 -> 7.88)

  • Declining Code Health: 3 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method test_safety_check.cpp: TEST:BehaviorPathPlanningSafetyUtilsTest:checkCollision
  • Excess Number of Function Arguments test_safety_check.cpp: create_rss_parameters
  • Excess Number of Function Arguments test_safety_check.cpp: create_path_with_velocity_and_polygon

Annotations

Check warning on line 612 in planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_safety_check.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method 

TEST:BehaviorPathPlanningSafetyUtilsTest:checkCollision has 71 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 78 in planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_safety_check.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

create_rss_parameters has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 96 in planning/behavior_path_planner/autoware_behavior_path_planner_common/test/test_safety_check.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

create_path_with_velocity_and_polygon has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis