feat(autoware_behavior_path_dynamic_obstacle_avoidance): expand drivable area #8295
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Sep 4, 2024 in 34s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.23 (4.39 -> 4.16)
-
Declining Code Health: 4 findings(s) 🚩
-
Affected Hotspots: 1 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Large Method manager.cpp: DynamicObstacleAvoidanceModuleManager::updateModuleParams
- Complex Method scene.cpp: DynamicObstacleAvoidanceModule::generateExpandedDrivableLanes 🔥
- Large Method manager.cpp: DynamicObstacleAvoidanceModuleManager::init
- Complex Method scene.cpp: DynamicObstacleAvoidanceModule::plan 🔥
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1538 to 1689, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
DynamicObstacleAvoidanceModule::plan increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
DynamicObstacleAvoidanceModule::generateExpandedDrivableLanes has a cyclomatic complexity of 24, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Bumpy Road Ahead
DynamicObstacleAvoidanceModule::generateExpandedDrivableLanes has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 6.52 to 6.63, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Deep, Nested Complexity
DynamicObstacleAvoidanceModule::generateExpandedDrivableLanes has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
DynamicObstacleAvoidanceModuleManager::updateModuleParams increases from 121 to 122 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
DynamicObstacleAvoidanceModuleManager::init increases from 96 to 97 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading