-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoware_
prefix to lanelet2_extension
#7640
feat: add autoware_
prefix to lanelet2_extension
#7640
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk |
I've tested the planning simulator with local @kosuke55 Thank you for your suggestion. I'm trying to check. |
Signed-off-by: Yutaka Kondo <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
To smoothly migrate, I modified to accommodate both the deprecated Once the Autoware Evaluator passed https://evaluation.tier4.jp/evaluation/reports/558069d2-166a-5c29-9815-e98bcc98fa8d?project_id=prd_jt, it would be mergable. |
@mitsudome-r @xmfcx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…t2-extension Signed-off-by: Yutaka Kondo <[email protected]>
😭
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7640 +/- ##
==========================================
+ Coverage 15.09% 24.24% +9.14%
==========================================
Files 1967 1002 -965
Lines 135941 78617 -57324
Branches 42122 31033 -11089
==========================================
- Hits 20520 19059 -1461
+ Misses 92700 56830 -35870
+ Partials 22721 2728 -19993
☔ View full report in Codecov by Sentry. |
I'm trying to fix the space issue here: For now since this has passed the non-cuda test, I will merge it bypassing the restriction. |
@xmfcx Thank you so much! |
I was just testing the build on local machine with cuda and confirmed that it builds fine. |
…ion#7640) Signed-off-by: Yutaka Kondo <[email protected]>
…ion#7640) Signed-off-by: Yutaka Kondo <[email protected]> Signed-off-by: palas21 <[email protected]>
…ion#7640) Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Description
This PR adds
autoware_
prefix tolanelet2_extension
.ref. https://github.com/orgs/autowarefoundation/discussions/4097
Additionally, this PR also changed the
autoware_lanelet2_extension
to pull from https://github.com/autowarefoundation/autoware_lanelet2_extension not from https://github.com/autowarefoundation/autoware_common.ref. https://github.com/orgs/autowarefoundation/discussions/4671
See also autowarefoundation/autoware#4909.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.