Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoware_ prefix to lanelet2_extension #7640

Merged
merged 12 commits into from
Jun 28, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jun 24, 2024

Description

This PR adds autoware_ prefix to lanelet2_extension.
ref. https://github.com/orgs/autowarefoundation/discussions/4097

Additionally, this PR also changed the autoware_lanelet2_extension to pull from https://github.com/autowarefoundation/autoware_lanelet2_extension not from https://github.com/autowarefoundation/autoware_common.
ref. https://github.com/orgs/autowarefoundation/discussions/4671

See also autowarefoundation/autoware#4909.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jun 24, 2024
youtalk and others added 2 commits June 25, 2024 10:33
@youtalk youtalk self-assigned this Jun 25, 2024
@kosuke55
Copy link
Contributor

@youtalk
Could you please adding any test result? (e.g. psim, lsim, evaluator)
For exmple, we often execute planning test on evaluator and compare with daily test result.
Please refer internal documentation to test with evaluator.

@youtalk
Copy link
Member Author

youtalk commented Jun 25, 2024

I've tested the planning simulator with local colcon build artifacts.
https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/planning-simulation/#basic-simulations

@kosuke55 Thank you for your suggestion. I'm trying to check.

Signed-off-by: Yutaka Kondo <[email protected]>
Copy link

github-actions bot commented Jun 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk
Copy link
Member Author

youtalk commented Jun 25, 2024

To smoothly migrate, I modified to accommodate both the deprecated lanelet2_extension and the new autoware_lanelet2_extension. The autoware_common remains but was changed a branch that removes autoware_cmake, autoware_lint_common, and autoware_utils. f1577fd

Once the Autoware Evaluator passed https://evaluation.tier4.jp/evaluation/reports/558069d2-166a-5c29-9815-e98bcc98fa8d?project_id=prd_jt, it would be mergable.

@youtalk
Copy link
Member Author

youtalk commented Jun 25, 2024

@mitsudome-r @xmfcx
Since https://evaluation.tier4.jp/evaluation/reports/558069d2-166a-5c29-9815-e98bcc98fa8d?project_id=prd_jt was passed, please review and merge by your bypass permission if approved.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 27, 2024
@youtalk youtalk added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:run-clang-tidy-differential and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 28, 2024
@youtalk
Copy link
Member Author

youtalk commented Jun 28, 2024

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.24%. Comparing base (3d849e9) to head (15d6cff).
Report is 535 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7640      +/-   ##
==========================================
+ Coverage   15.09%   24.24%   +9.14%     
==========================================
  Files        1967     1002     -965     
  Lines      135941    78617   -57324     
  Branches    42122    31033   -11089     
==========================================
- Hits        20520    19059    -1461     
+ Misses      92700    56830   -35870     
+ Partials    22721     2728   -19993     
Flag Coverage Δ
differential 24.24% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor

xmfcx commented Jun 28, 2024

I'm trying to fix the space issue here:

For now since this has passed the non-cuda test, I will merge it bypassing the restriction.

@xmfcx xmfcx merged commit d42e0bb into autowarefoundation:main Jun 28, 2024
49 of 53 checks passed
@youtalk youtalk deleted the use-autoware-lanelet2-extension branch June 28, 2024 08:27
@youtalk
Copy link
Member Author

youtalk commented Jun 28, 2024

@xmfcx Thank you so much!

@mitsudome-r
Copy link
Member

I was just testing the build on local machine with cuda and confirmed that it builds fine.

@xmfcx
Copy link
Contributor

xmfcx commented Jun 28, 2024

Next time you can use the workflow dispatch to validate too:

image

It will take time but it will validate with cuda.

mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants