Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gordon/feat/amp climb #20

Merged
merged 43 commits into from
Feb 17, 2024
Merged

Gordon/feat/amp climb #20

merged 43 commits into from
Feb 17, 2024

Conversation

gordonbchen
Copy link
Contributor

Description

Tune shoulder, elevator, and feeder. Add amp score and shooting commands.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue, add DEF # above in description)
  • Environment change (changes to developer environment or CI configuration)
  • Documentation Update (if none of the other choices apply)

How Has This Been Tested?

Ran in shop.

Author Checklist:

  • I have performed a self-review of my code
  • I have added 1-2 reviewers
  • I have @mentioned relevant non-reviewers as an FYI
  • I have included a detailed description of my changes and their motivations

Apple Pi Robotics and others added 30 commits January 29, 2024 18:37
add shooter subsystem and button binds
e5a5fde
@Devallex
Add Sensor
6c9e265
Added feeder sensor
43316a5
Add work on feeder and shooter
50893ae
lower shooting wait and remove commented code
6fa2ff4
Make FeedAndShoot Repeatedly
dc72724
increase shooting speed
e0a17e4
@gordonbchen
clean up shooter and feeder
6a1045e
@gordonbchen
stop feeder immediately after sensor detection
9ab8464
@gordonbchen
wait until game piece isn't detected before stopping shooter
774a812
@gordonbchen
create instance of feeder in robot container
cf5c504
@gordonbchen
Merge branch 'main' into gordon/janitor/feeder_shooter
93e7adc
@gordonbchen
log game piece sensor
e1ca4d9
@gordonbchen
run intake with feeder on feeding game piece
5049f13
@gordonbchen
remove dev intake command
1ddbd36
add amp scoring and climbing dev commands
a0a7eee
@gordonbchen
add dev code for feeder motion magic control
080e28c
@gordonbchen
fix max steer motor speed
86d5327
@gordonbchen
add dev code for intake motion magic
03d9261
@gordonbchen
invert shooter motor instead of multiplying by -1.0
1fed5e5
@gordonbchen
refactor shooter
f084532
@gordonbchen
refactor shooter within threshold
e0d579f
@gordonbchen
add elevator and shoulder position commands
6709e6a
@gordonbchen
add intake set percent output command
1f55c7b
tune feeder pids
f6c7ff0
add dev code
1c4411b
@gordonbchen
add magic motion accel todos
a6a4dc7
@gordonbchen
remove janky reverse command in feed game piece
8c4776a
@gordonbchen
remove unused robot container commands
b7d9e95
@gordonbchen
fix elevator and shoulder allowable error bug
5abdbcb
ApplePiRobot
ApplePiRobot reviewed Feb 17, 2024
View reviewed changes
Copy link
Contributor

@ApplePiRobot ApplePiRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good no problems that i can see, tested well on field. looks ready to merge

@gordonbchen gordonbchen merged commit 4ac0b91 into main Feb 17, 2024
1 check passed
@gordonbchen gordonbchen deleted the gordon/feat/amp_climb branch February 17, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApplePiRobot ApplePiRobot ApplePiRobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gordonbchen @ApplePiRobot @Devallex