shared stylelint-config-airbnb

[christophervoigt]

To be fair, most of this comes from #23 and serves #13, but instead of having to merge with @ntwb (:+1:) each time, I wanted to create my own for faster development.

So what's new?

• I mostly rewrote the package following the example of the current airbnb/javascript repository.
• I also added some basic tests to the package.

Please feel free to comment or suggest improvements.

[ntwb]

LGTM

[ntwb]

Great idea @chlorophyllkid, a quick cursory glance at everything looks 👌

I've now closed #56 🎉

[felixjung]

Neat, looking forward to this.

[christophervoigt]

I had to remove the rule 'scss/dollar-variable-pattern': '^foo' because having to start every variable with foo seems a bit odd. 😉
If it should be part of the ruleset again, a proper regular expression should be created to fit the naming conventions.

[christophervoigt]

Ok, I did a bunch of things today. Let me conclude:

I added the scss-lint file again, which I removed during the restructuring.
It took me a while to understand some of those rules, but in the end I added some new rules to the index.js of the new package, which now should hold every rule / recommendation of the current README and scss-lint. (please review) 😉

Tests are now in different files as well. The base-files are mostly for formatting rules and the sass-files are more specific to scss syntax.

[felixjung]

Hey there. Can we get any response from the maintainers on this? Would be great to get this going. 😃

[tony]

I'm excited about this. The tricky issue is airbnb apparently doesn't do stylelint in-house (#45), so I'm concerned that may cause friction with getting this in. They don't really have a way to maintain a shareable config if they don't use the linter.

So getting a yes/no response if airbnb is willing to officially support a stylelint config would be helpful. If the answer is no, it may be best to press forward with a separate repo. Aside: we could ask if stylelint organization would help, but the bigger picture is we need volunteers using stylelint that can help maintain it.

Doing some QA:

Was wondering the markdown lint stuff for. It's based off https://github.com/airbnb/javascript/tree/master/linters.

For reference, there is the layout of stylelint "shareable configs", which is pretty similar in spirit to what eslint offers:

• https://github.com/stylelint/stylelint-config-standard
• https://github.com/stylelint/stylelint-config-recommended

To try to get some more eyes on this, I'm posting an issue in stylelint/stylelint. stylelint/stylelint#3091

[ntwb]

So getting a yes/no response if airbnb is willing to officially support a stylelint config would be helpful.

Accepting a PR for this was green-lighted in #13 (comment)

Aside: we could ask if stylelint organization would help

I am one of the members of the stylelint org and created the original PR for this 😏

To try to get some more eyes on this, I'm posting an issue in stylelint/stylelint. stylelint/stylelint#3091

I've replied and closed that issue 😄

[tony]

Thanks for responding to stylelint/stylelint#3091

I'm glad to know stylelint is already greenlighted in #13. That will make this process smoother.

[christophervoigt]

but the bigger picture is we need volunteers using stylelint that can help maintain it.

I would be definitely up for this. :)

[ntwb]

I know Airbnb's shared ESlint configuration is popular and all but if all you're are after ia a shared stylelint configuration with some sane defaults to use in your projects then use:
• https://github.com/stylelint/stylelint-config-standard

The stylelint-config-standard configuration inherits:
• https://github.com/stylelint/stylelint-config-recommended

[christophervoigt]

I'm familiar with those, and I'm actually using stylelint-config-standard with some rule overrides. That wasn't the point of this PR and working towards this.
Since airbnb already acts for a lot of developers as a source of truth and good practise, I was wondering why this repository isn't an actual stylelint extention yet.

If airbnb decides to not merge those changes, I might end up copying a lot of those rules into my future project rulesets. 😄

[stevenleija]

Any updates on this?

[SilentImp]

So, actually, why it's still not merged?
Help needed?

[lencioni]

Thanks for the contribution! At a glance this looks pretty good to me. @ljharb can you review this when you have a chance?

[alisonps]

Hi! Are there any updates on the status of this?

[christophervoigt]

No, still waiting for the review of @ljharb and @mikefowler 🙂

[kytta]

...so? It's been 1.5 years. Is there even a point in waiting?

[tianzhich]

3 years later...😞

[christophervoigt]

I'm going to close this now ...this is clearly never going to happen. 😄

Thank you everyone for your patience. Stay Safe! 👋