Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include config 'stylelint-config-airbnb' #30

Closed
danielvijge opened this issue Jun 19, 2019 · 3 comments
Closed

Include config 'stylelint-config-airbnb' #30

danielvijge opened this issue Jun 19, 2019 · 3 comments

Comments

@danielvijge
Copy link
Contributor

Include the config stylelint-config-airbnb

@gilbarbara
Copy link
Owner

hey,
This package seems dead...
I merged your PR but while running the test locally it required an old version of stylelint and I couldn't find the repo to check dependencies.
So I'll remove it.

@danielvijge
Copy link
Contributor Author

Thanks for looking into this.

In the original merge request I didn't include a new package-lock.json, because there were many other merge requests as well, and I thought it might lead to merge conflicts. The old versions are devDependencies only. If a new package-lock.json file is generated with npm install --package-lock, it detects that stylelint-config-airbnb only depends on ava and editorconfig-tools.

Would you accept a new merge request that includes package-lock.json?

@gilbarbara
Copy link
Owner

The problem is that this package wasn't even merged in Airbnb's repo yet and the last update in the PR is from last year.
The published npm version (0.0.0!!) depends on deprecated node.js APIs.

I'm sorry but until the PR is merged and the package is officially maintained I can't add it. Try to send a message in that PR to see if things move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants