Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching: Include the node's class in objects to hash #6321

Merged
merged 1 commit into from
Mar 18, 2024

Commits on Mar 17, 2024

  1. Caching: Include the node's class in objects to hash

    The current implementation did not include the class of the node in the
    list of objects to include in the hash calculation. This made it
    possible for two nodes of different types but with the same attributes
    to have the same hash, as long as one type was a subclass of the other.
    
    Arguably when two nodes have a different type, even if subclasses, their
    hashes should never be the same. Therefore, the node's class is added to
    the list returned by `NodeCaching._get_objects_to_hash()`.
    sphuber committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    aa9a1c9 View commit details
    Browse the repository at this point in the history