Caching: Include the node's class in objects to hash #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation did not include the class of the node in the list of objects to include in the hash calculation. This made it possible for two nodes of different types but with the same attributes to have the same hash, as long as one type was a subclass of the other. Arguably when two nodes have a different type, even if subclasses, their hashes should never be the same. Therefore, the node's class is added to the list returned by `NodeCaching._get_objects_to_hash()`.
unkcpz
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Thanks @sphuber! This change makes a lot sense.
I realize it may also depend on the coding style, if using composition instead of inheritance, the problem does not manifest. https://realpython.com/inheritance-composition-python/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6320
The current implementation did not include the class of the node in the list of objects to include in the hash calculation. This made it possible for two nodes of different types but with the same attributes to have the same hash, as long as one type was a subclass of the other.
Arguably when two nodes have a different type, even if subclasses, their hashes should never be the same. Therefore, the node's class is added to the list returned by
NodeCaching._get_objects_to_hash().