Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Avoid caching state in lwd-update-sync job #9029

Merged

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Nov 15, 2024

Motivation

This test is failing in CI since #9004, it's not clear why it was passing before then as the expected log was missing before #9004 as well.

The test documentation says it's meant to be run with an empty Zebra and lightwalletd test (and it is consistent with the test code). The test should not be producing an updated cache state, it should never be saved to a cached disk for other tests to use.

Depends-On: #9026.

Solution

Sets the needs_zebra_state, needs_lwd_state, save_to_disk, and force_save_to_disk Github action inputs as false for the lightwalletd-update-sync job.

Related changes:

  • Checks if a branch is from a fork before all of the external patch jobs

Tests

The test should pass in CI for this PR.

PR Author's Checklist

  • The PR name will make sense to users.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests P-High 🔥 labels Nov 15, 2024
@arya2 arya2 self-assigned this Nov 15, 2024
@arya2 arya2 requested a review from a team as a code owner November 15, 2024 19:52
@arya2 arya2 requested review from oxarbitrage and removed request for a team November 15, 2024 19:52
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 15, 2024
@arya2 arya2 changed the base branch from disable-scan-where-left-test to main November 15, 2024 19:59
@arya2 arya2 force-pushed the disable-lwd-update-sync-save-to-disk branch from e2a43ad to 7a5bd98 Compare November 15, 2024 19:59
@arya2 arya2 requested a review from a team as a code owner November 15, 2024 20:10
@arya2 arya2 force-pushed the disable-lwd-update-sync-save-to-disk branch from 9ac9f30 to 9cade01 Compare November 15, 2024 20:11
@arya2 arya2 changed the base branch from main to disable-scan-where-left-test November 15, 2024 20:18
@oxarbitrage oxarbitrage merged commit f9cc055 into disable-scan-where-left-test Nov 15, 2024
152 checks passed
@oxarbitrage oxarbitrage deleted the disable-lwd-update-sync-save-to-disk branch November 15, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants