Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): remove scan-start-where-left-test from CI #9026

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(ci): remove scan-start-where-left-test from CI #9026

merged 1 commit into from
Nov 19, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Nov 15, 2024 •
edited
Loading

Motivation

The scan_start_where_left test is failing our CI apparently for this reason.

Solution

  • Instead of fixing it we want to disable the scan_start_where_left test from the workflow keeping the rust test available for local runs.

Tests

CI should not fail in this test as it will not be there anymore.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added A-devops Area: Pipelines, CI/CD and Dockerfiles C-removal Category: Features that have been removed A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ labels Nov 15, 2024
@oxarbitrage oxarbitrage self-assigned this Nov 15, 2024
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Nov 15, 2024
@oxarbitrage oxarbitrage marked this pull request as ready for review November 15, 2024 18:37
@oxarbitrage oxarbitrage requested a review from a team as a code owner November 15, 2024 18:37
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team November 15, 2024 18:37
@oxarbitrage oxarbitrage removed the extra-reviews This PR needs at least 2 reviews to merge label Nov 15, 2024
arya2
arya2 previously approved these changes Nov 15, 2024
View reviewed changes
@arya2 arya2 mentioned this pull request Nov 15, 2024
Merged
6 tasks
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Nov 15, 2024
@oxarbitrage oxarbitrage changed the title Remove scan-start-where-left-test from CI Remove scan-start-where-left-test from CI and avoid caching state in lwd-update-sync job Nov 15, 2024
arya2
arya2 previously approved these changes Nov 15, 2024
View reviewed changes
@mpguerra
Copy link
Contributor

@mergify refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

refresh

✅ Pull request refreshed

@oxarbitrage oxarbitrage changed the title Remove scan-start-where-left-test from CI and avoid caching state in lwd-update-sync job Remove scan-start-where-left-test from CI Nov 18, 2024
@gustavovalverde gustavovalverde changed the title Remove scan-start-where-left-test from CI fix(ci): remove scan-start-where-left-test from CI Nov 18, 2024
@gustavovalverde gustavovalverde removed the extra-reviews This PR needs at least 2 reviews to merge label Nov 18, 2024
@mpguerra mpguerra merged commit 17648cc into main Nov 19, 2024
288 of 290 checks passed
@mpguerra mpguerra deleted the disable-scan-where-left-test branch November 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 left review comments

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@oxarbitrage oxarbitrage

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-devops Area: Pipelines, CI/CD and Dockerfiles C-removal Category: Features that have been removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oxarbitrage @mpguerra @arya2 @gustavovalverde