Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add priority tax reactor #252

Merged
merged 27 commits into from
Jul 25, 2024
Merged

feat: add priority tax reactor #252

merged 27 commits into from
Jul 25, 2024

Commits on Jun 24, 2024

  1. initial commit - priority fee reactor, lib, and structs

    @zhongeric
    zhongeric committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a9eb24f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Implement reactor, add tests and library tests

    @zhongeric
    zhongeric committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d088055 View commit details
    Browse the repository at this point in the history

  2. forge fmt

    @zhongeric
    zhongeric committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9e3be03 View commit details
    Browse the repository at this point in the history

  3. Add validation tests

    @zhongeric
    zhongeric committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f22304b View commit details
    Browse the repository at this point in the history

  4. nit: comment

    @zhongeric
    zhongeric committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    462e73c View commit details
    Browse the repository at this point in the history

  5. change to MPS

    @zhongeric
    zhongeric committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b6507ec View commit details
    Browse the repository at this point in the history

  6. forge fmt

    @zhongeric
    zhongeric committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    733ea41 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. remove unchecked loop

    @zhongeric
    zhongeric committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    24e3387 View commit details
    Browse the repository at this point in the history

  2. add comment

    @zhongeric
    zhongeric committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a3e462c View commit details
    Browse the repository at this point in the history

  3. replace mps with pips

    @zhongeric
    zhongeric committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7d90457 View commit details
    Browse the repository at this point in the history

  4. rename back to mps

    @zhongeric
    zhongeric committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4160c07 View commit details
    Browse the repository at this point in the history

  5. fix comment and test

    @zhongeric
    zhongeric committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    939fdd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. add comment

    @zhongeric
    zhongeric committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    109c580 View commit details
    Browse the repository at this point in the history

  2. Set maxAmount to original input amount to fix token permissions error

    @zhongeric
    zhongeric committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    45cc9f6 View commit details
    Browse the repository at this point in the history

  3. forge fmt

    @zhongeric
    zhongeric committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3b5d55b View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. comments: cache value in lib

    @zhongeric
    zhongeric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c0e0cdd View commit details
    Browse the repository at this point in the history

  2. Add explicit edge case priority fee lib tests

    @zhongeric
    zhongeric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b0d1a6d View commit details
    Browse the repository at this point in the history

  3. forge fmt

    @zhongeric
    zhongeric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    91d7201 View commit details
    Browse the repository at this point in the history

  4. add tests

    @zhongeric
    zhongeric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8bcf907 View commit details
    Browse the repository at this point in the history

  5. add baseFee assert

    @zhongeric
    zhongeric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7e71e07 View commit details
    Browse the repository at this point in the history

  6. forge fmt

    @zhongeric
    zhongeric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    98b47bc View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. feat: add cosigner logic and minPriorityFee (#254) 

    * Add cosigner logic

* Add invalid cosigner and cosignature tests

* Add minPriorityFee

* remove openAuctionStartBlock

* add revert test for filling before cosigner and before auction start block

* remove unused error

* Only validate cosignature if before auctionStartBlock

* add custom revert for txGasprice < block base fee

* add revert test for txgasprice

* remove view modifier

* only call updateCosignerData func if before auctionStartBlock

* move getPriorityFee into separate func

* fix compiler warnings for tests

---------

Co-authored-by: ConjunctiveNormalForm <[email protected]>
    @zhongeric @ConjunctiveNormalForm
    zhongeric and ConjunctiveNormalForm authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    666d57d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix: cosigner verification edge cases and other fixes (#255) 

    * move cosigner verification logic into validate

* Add cosignerlib

* nit: comments

* Add tests to CosignerLib

* flip and forge fmt
    @zhongeric
    zhongeric authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7c4330f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Fix 712 ordering (#258)

    @zhongeric
    zhongeric authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b26c523 View commit details
    Browse the repository at this point in the history

  2. chore: add better gas coverage for priority orders

    @zhongeric
    zhongeric committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    25237d0 View commit details
    Browse the repository at this point in the history

  3. fix gas snaps

    @zhongeric
    zhongeric committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    77c9cba View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. feat: revert quickly if order is already filled (#259) 

    * revert quickly if invalid nonce

* update gas snaps

* add tests for invalid nonces

* Change revert to OrderAlreadyFilled

* forge fmt

* rm console2
    @zhongeric
    zhongeric authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f77785b View commit details
    Browse the repository at this point in the history