feat: add priority tax reactor #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
reviewed
Jun 25, 2024
snreynolds
reviewed
Jul 1, 2024
* Add cosigner logic * Add invalid cosigner and cosignature tests * Add minPriorityFee * remove openAuctionStartBlock * add revert test for filling before cosigner and before auction start block * remove unused error * Only validate cosignature if before auctionStartBlock * add custom revert for txGasprice < block base fee * add revert test for txgasprice * remove view modifier * only call updateCosignerData func if before auctionStartBlock * move getPriorityFee into separate func * fix compiler warnings for tests --------- Co-authored-by: ConjunctiveNormalForm <[email protected]>
* move cosigner verification logic into validate * Add cosignerlib * nit: comments * Add tests to CosignerLib * flip and forge fmt
* revert quickly if invalid nonce * update gas snaps * add tests for invalid nonces * Change revert to OrderAlreadyFilled * forge fmt * rm console2
marktoda
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new reactor type, PriorityOrderReactor, which scales the output amount required to fill an order by the priority fee set in the filling transaction