Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caff 80 #92

Merged
merged 15 commits into from
May 22, 2022
Merged

Caff 80 #92

merged 15 commits into from
May 22, 2022

Conversation

1999michael
Copy link
Contributor

holdup, lemme look at the code and make it PR-able

kajananchinniah
kajananchinniah requested changes May 22, 2022
View reviewed changes
Copy link
Collaborator

@kajananchinniah kajananchinniah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't view changes done to the worlds. But why was the world changed?

Other than that, lgtm I guess, due to time I won't be too strict on review

description/launch/simulate.launch Show resolved Hide resolved
description/urdf/constants.xacro Outdated Show resolved Hide resolved
description/urdf/constants.xacro Outdated Show resolved Hide resolved
nav/load_waypoints/scripts/navigate_waypoints.py Show resolved Hide resolved
nav/load_waypoints/scripts/navigate_waypoints.py Outdated Show resolved Hide resolved
nav/load_waypoints/scripts/navigate_waypoints.py Outdated Show resolved Hide resolved
nav/load_waypoints/scripts/navigate_waypoints.py Show resolved Hide resolved
nav/nav_stack/CMakeLists.txt Outdated Show resolved Hide resolved
nav/load_waypoints/scripts/static_waypoints.json Show resolved Hide resolved
nav/load_waypoints/scripts/static_waypoints_xy.json Outdated Show resolved Hide resolved
@1999michael 1999michael linked an issue May 22, 2022 that may be closed by this pull request
P0 - Navigate without Human Intervention #80
Open
1 task
@kajananchinniah kajananchinniah self-requested a review May 22, 2022 21:58
kajananchinniah
kajananchinniah approved these changes May 22, 2022
View reviewed changes
Copy link
Collaborator

@kajananchinniah kajananchinniah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please deal with the comments I left

@1999michael 1999michael merged commit 8af8600 into master May 22, 2022
@1999michael 1999michael removed a link to an issue May 22, 2022
P0 - Navigate without Human Intervention #80
Open
1 task
@kajananchinniah kajananchinniah deleted the CAFF-80 branch May 23, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kajananchinniah kajananchinniah kajananchinniah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1999michael @kajananchinniah @Anthonyjlem