Split ServerAddon into new file

[johansenja]

• It is able to benefit from strict typing now removed because of some runtime problems
• It simplifies server.rb
• It is now possible to require it specifically in other files, eg if you want to write tests for your server addon, you can require the server addon file specifically

I originially had some other changes here too, but there are no longer needed!

[vinistock]

Thank you for the PR! I think extracting the server addon definition to another file is fine, but the rails runner client changes are breaking some of the conventions we're putting in place

[johansenja]

Thanks for the feedback! The comments definitely make sense and so I've taken out two of the commits which would no longer be necessary - leaving this just with the changes to move ServerAddon into a new file (and have updated description and title accordingly). IMO this change could still be useful to split up server.rb, and to give the addon typings - but of course I leave it up to you to make the decision!

[vinistock]

@andyw8 now that I think about it, didn't we hit issues when trying to require the Sorbet runtime in the server? If my memory serves me right, it sometimes led to issues with the application.

Maybe we could just split the files, but still make that one untyped.

[andyw8]

Yes, I remember there was a problem, but not the exact details.

I agree with the splitting, but for now let's keep sorbet-runtime out of the server to reduce the risk.

[andyw8]

Since .rubocop.yml was updated I think this shouldn't be needed?

[vinistock]

This needs a rebase, but the split looks good

[andyw8]

Hi @johansenja, are you hoping to continue on this?