[Tapioca add-on] Add ServerAddon boilerplate
#2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
changed the title
ServerAddon boilerplate
KaanOzkan
force-pushed
the
ko/add-server-addon-boilerplate
branch
from
d2aba8c
to
f8e9851
Compare
KaanOzkan
commented
Oct 7, 2024
| @@ -45,6 +45,8 @@ Sorbet/TrueSigil: | |||
| Include: | |||
| - "**/*.rb" | |||
| - "**/*.rake" | |||
| Exclude: | |||
| - "lib/ruby_lsp/tapioca/server_addon.rb" | |||
There was a problem hiding this comment.
Following the discussion on Shopify/ruby-lsp-rails#469 (comment). I'd like to somehow ensure sigs don't get added to the file in the future.
vinistock
reviewed
Oct 7, 2024
KaanOzkan
force-pushed
the
ko/add-server-addon-boilerplate
branch
from
f8e9851
to
a47db64
Compare
vinistock
approved these changes
Oct 7, 2024
KaanOzkan
force-pushed
the
ko/add-server-addon-boilerplate
branch
from
a47db64
to
0935d45
Compare
KaanOzkan
commented
Oct 7, 2024
| @@ -62,6 +61,9 @@ def version | |||
|
|
|||
| sig { params(changes: T::Array[{ uri: String, type: Integer }]).void } | |||
| def workspace_did_change_watched_files(changes) | |||
| return unless T.must(@global_state).experimental_features | |||
| return unless @rails_runner_client # Client is not ready | |||
There was a problem hiding this comment.
I personally prefer multiple unless calls over combining them and thinking of De Morgan's Laws 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add ServerAddon usage to be called by Rails app based on main...andyw8/tapioca-lsp
Implementation
Tests