Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing role button attribute to the button links #19535

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@
[routerLink]="{ cxRoute: 'cart' } | cxUrl"
(click)="dismissModal('View Cart click')"
class="btn btn-primary"
role="button"
autofocus
>{{ 'addToCart.viewCart' | cxTranslate }}</a
>
Expand All @@ -130,6 +131,7 @@
[routerLink]="{ cxRoute: 'checkout' } | cxUrl"
(click)="dismissModal('Proceed To Checkout click')"
class="btn btn-secondary"
role="button"
>{{ 'addToCart.proceedToCheckout' | cxTranslate }}</a
>
</ng-container>
Expand Down Expand Up @@ -273,6 +275,7 @@
[routerLink]="{ cxRoute: 'cart' } | cxUrl"
(click)="dismissModal('View Cart click')"
class="btn btn-primary"
role="button"
autofocus
>{{ 'addToCart.viewCart' | cxTranslate }}</a
>
Expand All @@ -281,6 +284,7 @@
[routerLink]="{ cxRoute: 'checkout' } | cxUrl"
(click)="dismissModal('Proceed To Checkout click')"
class="btn btn-secondary"
role="button"
>{{ 'addToCart.proceedToCheckout' | cxTranslate }}</a
>
</ng-container>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
<ng-container *ngIf="hasStock">
<a
class="btn btn-link button-add-link cx-action-link"
role="button"
[routerLink]="{ cxRoute: 'login' } | cxUrl"
>
<cx-icon aria-hidden="true" [type]="iconTypes.EMPTY_HEART"></cx-icon>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ <h2 *ngIf="!type.replenishmentOrder">
<a
[routerLink]="{ cxRoute: 'home' } | cxUrl"
routerLinkActive="active"
role="button"
class="btn btn-primary btn-block"
>{{ 'orderHistory.startShopping' | cxTranslate }}</a
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ <h3>
[routerLink]="{ cxRoute: 'home' } | cxUrl"
routerLinkActive="active"
class="btn btn-primary btn-block"
role="button"
>{{ 'orderHistory.startShopping' | cxTranslate }}</a
>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
[routerLink]="{ cxRoute: 'home' } | cxUrl"
routerLinkActive="active"
class="btn btn-primary btn-block"
role="button"
>{{ 'unitLevelOrderHistory.startShopping' | cxTranslate }}</a
>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
productCode: product.code,
}"
class="btn btn-primary btn-block"
role="button"
cxAutoFocus
[attr.aria-label]="
getAriaLabelTranslationKey(product.configuratorType) | cxTranslate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
target="_blank"
rel="noopener noreferrer"
class="btn btn-sm btn-secondary btn-block cx-button"
role="button"
(click)="$event.stopPropagation()"
[attr.aria-label]="'storeFinder.ariaLabelGetDirections' | cxTranslate"
>{{ 'storeFinder.getDirections' | cxTranslate }}</a
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ <h3>
dismissDialog('Proceed To Login', reconsentEvent.errorMessage)
"
class="btn btn-primary"
role="button"
autofocus
>{{ 'common.submit' | cxTranslate }}</a
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"
[attr.aria-label]="'cancelService.action' | cxTranslate"
class="btn btn-secondary"
role="button"
>
{{ 'cancelService.action' | cxTranslate }}
</a>
Expand All @@ -34,6 +35,7 @@
'rescheduleService.actionButtonLabel' | cxTranslate
"
class="btn btn-secondary"
role="button"
>
{{ 'rescheduleService.actionButtonLabel' | cxTranslate }}
</a>
Expand Down
Loading