Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing role button attribute to the button links #19535

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: add missing role button attribute to the button links #19535

wants to merge 3 commits into from

Conversation

uroslates
Copy link
Contributor

@uroslates uroslates requested a review from a team as a code owner November 13, 2024 10:30
@github-actions github-actions bot marked this pull request as draft November 13, 2024 10:30
@uroslates uroslates marked this pull request as ready for review November 13, 2024 11:21
@uroslates uroslates requested review from a team as code owners November 13, 2024 11:21
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft November 13, 2024 11:22
@uroslates uroslates marked this pull request as ready for review November 13, 2024 11:22
@cypress Cypress
Copy link

cypress bot commented Nov 13, 2024

spartacus    Run #45741

Run Properties:  status check passed Passed #45741  •  git commit ec6398a60c ℹ️: Merge 9700826d5236858bbbffa554ddad1d61b64a0e32 into e28507687dbc12d0baf37a0e3ad0...
Project spartacus
Branch Review feature/CXSPA-8806
Run status status check passed Passed #45741
Run duration 03m 54s
Commit git commit ec6398a60c ℹ️: Merge 9700826d5236858bbbffa554ddad1d61b64a0e32 into e28507687dbc12d0baf37a0e3ad0...
Committer Uros Lates
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@developpeurweb
Copy link
Contributor

@uroslates as per requirement in the ticket, it must be possible to interact with converted elements with both Spacebar and Enter keys.
Currently they can only be activated using Enter as regular links. Can you please make sure all converted elements can also be activated using Spacebar.
Please ping me if you have any questions.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pio-Bar Pio-Bar Pio-Bar approved these changes

@Zeyber Zeyber Zeyber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uroslates @developpeurweb @Zeyber @Pio-Bar @ulates-sap