[setup] Update cloud packaging for EGL #22197
Open
+6
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
release notes: fix
Add ubuntu dependency on libegl1 so that it can be dlopen'd. Remove xvfb from deepnote.
jwnimmer-tri
force-pushed
the
deepnote
branch
from
cd5b70f
to
b055328
Compare
|
+@rpoyner-tri for feature review, please. |
|
At some point, I should also change this exception message to give better help (e.g., link to a troubleshooting guide): I can do that in this same PR if you like, or save it for a later one? |
rpoyner-tri
reviewed
Nov 15, 2024
There was a problem hiding this comment.
I'm fine with a separate PR for error message improvements.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
|
+@sammy-tri for platform review per schedule, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ubuntu dependency on libegl1 so that it can be dlopen'd. Document the same in the pip error message sidecar.
Remove xvfb from deepnote. Now that Drake defaults to using EGL, we no longer need a DISPLAY in the cloud.
This change is