RenderEngineVtk can be forced into PBR mode #22170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new parameter to RenderEngineVtkParams. Rather than waiting for the engine's lighting model to get promoted based on its content, it can be pushed into that mode upon construction. This also fixes a bug in which cloned instances forgot whether or not phong materials should be automatically promoted to PBR.
SeanCurtis-TRI
added
release notes: fix
SeanCurtis-TRI
commented
Nov 13, 2024
There was a problem hiding this comment.
+(release notes: feature) for the new RenderEngineVtkParams field.
+(release notes: fix) for the correction in post-clone behavior.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter to RenderEngineVtkParams. Rather than waiting for the engine's lighting model to get promoted based on its content, it can be pushed into that mode upon construction.
This also fixes a bug in which cloned instances forgot whether or not phong materials should be automatically promoted to PBR.
This change is