-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rolling CI #338
Disable rolling CI #338
Conversation
Signed-off-by: Aditya Pande <[email protected]>
Signed-off-by: Aditya Pande <[email protected]>
My preference would be to simply turn off the |
Signed-off-by: Aditya Pande <[email protected]>
Signed-off-by: Aditya Pande <[email protected]>
Signed-off-by: Aditya Pande <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a small nit around the commented code.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @adityapande-1995, @ahcorde, and @calderpg-tri)
.github/workflows/main.yml
line 18 at r2 (raw file):
include: #- os_code_name: jammy # ros_distro: rolling
Nit: My preference would be to remove these dead code comments and add a TODO to re-add rolling if / when backward compatible support of some sort comes along, whether it be tarball or Debian.
Signed-off-by: Aditya Pande <[email protected]>
Rolling is moving to Ubuntu Noble, and won't be releasing new packages on Jammy.
This change is