Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rolling CI #338

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Disable rolling CI #338

merged 6 commits into from
Mar 19, 2024

Conversation

adityapande-1995
Copy link
Collaborator

@adityapande-1995 adityapande-1995 commented Mar 11, 2024

Rolling is moving to Ubuntu Noble, and won't be releasing new packages on Jammy.


This change is Reviewable

Signed-off-by: Aditya Pande <[email protected]>
@adityapande-1995 adityapande-1995 changed the title CI fix for test_msgs CI failure test - draft PR Mar 11, 2024
Signed-off-by: Aditya Pande <[email protected]>
@adityapande-1995 adityapande-1995 changed the title CI failure test - draft PR Move CI from rolling to iron Mar 11, 2024
@IanTheEngineer
Copy link
Member

My preference would be to simply turn off the rolling CI job for now. I don't think we wish to support Iron as it isn't an LTS and will go EoL in November of 2024 anyway.

Signed-off-by: Aditya Pande <[email protected]>
@adityapande-1995 adityapande-1995 changed the title Move CI from rolling to iron Disable rolling CI Mar 12, 2024
Signed-off-by: Aditya Pande <[email protected]>
Signed-off-by: Aditya Pande <[email protected]>
@adityapande-1995 adityapande-1995 marked this pull request as ready for review March 12, 2024 21:03
Copy link
Member

@IanTheEngineer IanTheEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: I just have a small nit around the commented code.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @adityapande-1995, @ahcorde, and @calderpg-tri)


.github/workflows/main.yml line 18 at r2 (raw file):

        include:
          #- os_code_name: jammy
          #  ros_distro: rolling

Nit: My preference would be to remove these dead code comments and add a TODO to re-add rolling if / when backward compatible support of some sort comes along, whether it be tarball or Debian.

Signed-off-by: Aditya Pande <[email protected]>
@adityapande-1995 adityapande-1995 merged commit 301b4de into main Mar 19, 2024
5 of 6 checks passed
@adityapande-1995 adityapande-1995 deleted the aditya/ci_fix_test_msgs branch March 19, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants