-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] base_user_role: Add role_ids column to tree view. #250
Conversation
cc9b852
to
7e6b186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minors remarks.
Otherwise, LGTM. Thanks !
base_user_role/__manifest__.py
Outdated
@@ -4,7 +4,7 @@ | |||
|
|||
{ | |||
"name": "User roles", | |||
"version": "15.0.0.3.4", | |||
"version": "15.0.0.3.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to bump the version, it will be done automatically when merging.
(and it can avoid conflict).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good trick. I'll have to see about adding it to the pre-commit of my own modules.
base_user_role/views/user.xml
Outdated
@@ -39,4 +39,14 @@ | |||
</field> | |||
</field> | |||
</record> | |||
<record id="view_res_users_tree_inherit" model="ir.ui.view"> | |||
<field name="name">res.users.tree.inherit</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking point : FYI this field is useless. (and is autogenerated, if not set).
base_user_role/views/user.xml
Outdated
<field name="model">res.users</field> | ||
<field name="inherit_id" ref="base.view_users_tree" /> | ||
<field name="arch" type="xml"> | ||
<field name="company_id" position="after"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<field name="company_id" position="after"> | |
<field name="company_id" position="before"> |
In odoo, the company_id field is usually the last column of the tree view. So better to keep that design, and set the value before.
The role_ids field is already searchable in list view, now it is also displayed.
7e6b186
to
652e1b4
Compare
Thanks ! /ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at e6b15bb. Thanks a lot for contributing to OCA. ❤️ |
The role_ids field is already searchable in list view, now it is also displayed.