Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] base_user_role: Add role_ids column to tree view. #250

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

amh-mw
Copy link

@amh-mw amh-mw commented Nov 15, 2023

The role_ids field is already searchable in list view, now it is also displayed.

Screenshot 2023-11-15 at 10 49 28 AM

@OCA-git-bot
Copy link
Contributor

Hi @novawish, @sebalix, @jcdrubay,
some modules you are maintaining are being modified, check this out!

@amh-mw amh-mw force-pushed the 15-base_user_role-tree_show_role branch from cc9b852 to 7e6b186 Compare November 15, 2023 16:05
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minors remarks.
Otherwise, LGTM. Thanks !

@@ -4,7 +4,7 @@

{
"name": "User roles",
"version": "15.0.0.3.4",
"version": "15.0.0.3.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to bump the version, it will be done automatically when merging.
(and it can avoid conflict).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good trick. I'll have to see about adding it to the pre-commit of my own modules.

@@ -39,4 +39,14 @@
</field>
</field>
</record>
<record id="view_res_users_tree_inherit" model="ir.ui.view">
<field name="name">res.users.tree.inherit</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking point : FYI this field is useless. (and is autogenerated, if not set).

<field name="model">res.users</field>
<field name="inherit_id" ref="base.view_users_tree" />
<field name="arch" type="xml">
<field name="company_id" position="after">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="company_id" position="after">
<field name="company_id" position="before">

In odoo, the company_id field is usually the last column of the tree view. So better to keep that design, and set the value before.

The role_ids field is already searchable in list view, now it is
also displayed.
@amh-mw amh-mw force-pushed the 15-base_user_role-tree_show_role branch from 7e6b186 to 652e1b4 Compare December 13, 2023 20:58
@legalsylvain
Copy link
Contributor

Thanks !

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-250-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5caa145 into OCA:15.0 Dec 13, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e6b15bb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants