Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [MIG] base_user_role: Migration to 17.0 #253

Merged
merged 123 commits into from
Feb 9, 2024

Conversation

rven
Copy link

@rven rven commented Dec 13, 2023

No description provided.

sebalix and others added 30 commits December 13, 2023 14:47
…608)

* [ADD] New module 'base_user_role'

* [FIX] base_user_role - Review

* [FIX] base_user_role - Review s/is_active/is_enabled/

* [FIX] base_user_role - Review s/is_active/is_enabled/

* [IMP] base_user_role - Translations updated (template + FR)

* [FIX] base_user_role - Lint
* FIX: Update users' groups when a role is deleted
* IMP: add some test cases to check user's groups when its last role line is removed
* FIX: ensure that the user's groups are updated when its last role line is removed
Currently translated at 100,0% (37 of 37 strings)

Translation: server-backend-11.0/server-backend-11.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-11-0/server-backend-11-0-base_user_role/da/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
the groups that have changed with respecto the role.
…users.role.line"

This reverts commit b537941d5a2d1fcb3fbacc602124c1b3f6e1d495.
Ivorra78 and others added 13 commits December 13, 2023 14:47
Currently translated at 100.0% (58 of 58 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role/es/
Currently translated at 100.0% (58 of 58 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role/es/
Currently translated at 100.0% (58 of 58 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role/pt/
Currently translated at 27.5% (16 of 58 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-16.0/server-backend-16.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role/
Currently translated at 100.0% (59 of 59 strings)

Translation: server-backend-16.0/server-backend-16.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_role/es/
@rven rven mentioned this pull request Dec 13, 2023
10 tasks
@legalsylvain
Copy link
Contributor

Hi. Thanks for porting this module.
could you cherry pick this recent commit : #250

thanks !

The role_ids field is already searchable in list view, now it is
also displayed.
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff review. LGTM.

@sebalix, @jcdrubay, @novawish : could you take a look on this module you are maintaining.

thanks !

@legalsylvain
Copy link
Contributor

/ocabot migration base_user_role

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 30, 2024
Copy link
Member

@gaikaz gaikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@legalsylvain
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-253-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit da63559 into OCA:17.0 Feb 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5f12738. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.